Possible Bug - Import entities

Hi Derick,

I have prepared a sample. I have put the zip on our webserver:

http://71.164.192.3/ImportSL.zip

I have not used any frameworks with this sample, so it's not all best practices!

You will see two 'screens'

the top is the customer screen that lets you add/edit an address, when you click one of these buttons you will be able to update the address screen.

If you edit the address and save it, then save and edit again, you will see it starts duplicating the data. You will see it is not merging it in properly.

If you have any questions on it please let me know.

Thanks,

Mark

Yes, you're correct. SaveChanges will not pick those entities up when you use AcceptChanges. So in the broader scenario, SetModified is probably preferable. All the more reason for me to figure out why I can't repro the above issue outside the solution. It should be as simple as importing the same modified entity again but it doesn't generate duplicate in my test project when I do that.

I appreciate the help Mark. Thanks!

This is what I've had to do to make things work. It's not pretty, but it works.

When I load a sandboxed editor up I merge the data in like this:

            OriginalManager.FindEntities<Entity>(EntityState.Added)
                .ForEach(e =>
                                 {
                                     e.EntityAspect.AcceptChanges();
                                     e.EntityAspect.SetModified();
                                 });
 
            var restoreStrategy = new RestoreStrategy(false, false, MergeStrategy.OverwriteChanges);
            var data = repositoryBase.Manager.CacheStateManager.GetCacheState();
            NewManager.CacheStateManager.RestoreCacheState(data, restoreStrategy);
 
            var entities = Manager.FindEntities<Entity>(EntityState.Modified)
                .Where(e => (int)e.EntityAspect.EntityKey.Values[0] < 0).ToList();
 
            entities.ForEach(e => e.EntityAspect.SetAdded());


To stop the new manager from assigning a new Id, I have to call AcceptChanges and then SetModified.

Since I am using integer primary keys, I can find the true "Added" entities by finding the ones with a negative key. I then set these back to Added in the new manager.
Also, to get around duplicating the same negative key, I have had to alter the default ID generator. It now uses a static _nextId variable so that all instances use the same id counter.

This seems to work, the only issue is on saving where even though they are set to added, they get duplicated in the EM after saving, the original Added entities, and the new saved unchanged entities.

I have had to do this to get around it:

        private void OnSaveSuccess()
        {
            var addedEntities = Manager.FindEntities(EntityState.Added)
                .OfType<Entity>()
                .ToList();
 
            for (var i = addedEntities.Count-1; i >= 0; i--)
            {
                addedEntities.EntityAspect.Delete();
            }
        }

If there is a better/cleaner way of doing this, I'm all ears.

Edited by smi-mark - 01-Nov-2011 at 5:00pm

If I don't set it back to Added, it causes an error, at least under fake context, saying it can't find the entity.

"Unable to locate entity within the 'Fake' entity server: DealerAddress: -101"

Yes, this happens during SaveChanges and using the latest 6.1.3.1

I don't need a patch right away, my workaround seems to do the trick for now. I simply delete any modified entities after a save.

Thanks for looking into it, much appreciated. Will this and the the deletion merging issue be fixed in 6.1.4?