Catching TaskCanceledException

In StaffingResourcePhoneListViewModel, there is an Add() method which calls:

await _dialogManager.ShowDialogAsync(phoneTypeSelector, DialogButtons.OkCancel);

Shouldn't this be in a Try-Catch to catch a TaskCanceledException? It will throw this if the user clicks on cancel in the Phone type dialog.

Greg

There is no logic to be executed if the user decides to cancel, so what are you going to put in the catch? The TaskCanceledException will bubble up as an unhandled exception and ultimate ignored in the ErrorHandler. If you don't like unhandled exceptions, then you would put a try/catch around it and hand the exception directly to the ErrorHandler, where it will get ignored.