Possible Bug - Import entities

Hi Derick,

I have prepared a sample. I have put the zip on our webserver:

http://71.164.192.3/ImportSL.zip

I have not used any frameworks with this sample, so it's not all best practices!

You will see two 'screens'

the top is the customer screen that lets you add/edit an address, when you click one of these buttons you will be able to update the address screen.

If you edit the address and save it, then save and edit again, you will see it starts duplicating the data. You will see it is not merging it in properly.

If you have any questions on it please let me know.

Thanks,

Mark

Hi smi-mark;

Hi Denis,

Using AcceptChanges or SetModified by it self didn't work, but I do seem to have a solution:

I create a list of entities from EM2 with a state of Added, call AcceptChanges, import to EM1

For each Added Entity in EM2 i find the Entity using FindEntity EntityKey in EM1 and call SetAdded on it, this keeps the temporary Id and seems to work.

var addedEntities = fromManager.FindEntities(EntityState.Added)                 .OfType<Entity>()                 .ToList(); addedEntities.ForEach(e => e.EntityAspect.AcceptChanges()); toManager.ImportEntities(addedEntities, MergeStrategy.OverwriteChanges); addedEntities.Select(entity => toManager.FindEntity(entity.EntityAspect.EntityKey) as Entity) .ForEach(e => e.EntityAspect.SetAdded());

Edited by smi-mark - 22-Apr-2011 at 11:21am

Hi smi-mark;

Edited by DenisK - 19-Apr-2011 at 1:10pm

I have found a workaround for both problems.

For the first problem, as above, I just call it twice.

For the second problem, I do it like this:

        public static void ImportFrom(this EntityManager manager, EntityManager fromManager)
        {
            var addedEntities = fromManager.FindEntities(EntityState.Added).OfType<Entity>().ToList();
            fromManager.RemoveEntities(addedEntities);
            manager.ImportEntities(fromManager.FindEntities(EntityState.AllButDetached), MergeStrategy.OverwriteChanges);
            manager.AddEntities(addedEntities);
        }


Edited by smi-mark - 01-Apr-2011 at 4:16pm

Hi Denis,

This how you can reproduce it:

var mgr1 = new TestEntities();
var mgr2 = new TestEntities();

var customer = mgr1.CreateEntity<Customer>();
customer.Name = "Test";

mgr1.AddEntity(customer);

mgr2.ImportEntities(mgr1.FindEntities<Customer>(EntityState.AllButDetached), MergeStrategy.OverwriteChanges);

Console.WriteLine("Mgr1 count {0} Mgr2 count {1}",
    mgr1.FindEntities<Customer>(EntityState.AllButDetached).Count(),
    mgr2.FindEntities<Customer>(EntityState.AllButDetached).Count());

mgr1.ImportEntities(mgr2.FindEntities<Customer>(EntityState.AllButDetached), MergeStrategy.OverwriteChanges);

Console.WriteLine("Mgr1 count {0} Mgr2 count {1}",
    mgr1.FindEntities<Customer>(EntityState.AllButDetached).Count(),
    mgr2.FindEntities<Customer>(EntityState.AllButDetached).Count());

foreach (var c in mgr1.FindEntities<Customer>(EntityState.AnyAddedModifiedOrDeleted))
{
    Console.WriteLine("{0} {1}", c.Id, c.Name);
}




You will see mgr1 now has the same entity twice, but with a different id


Edited by smi-mark - 31-Mar-2011 at 7:59pm